Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support TAP format for test results #18

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Conversation

mdonnalley
Copy link
Contributor

What does this PR do?

  • Add support for formatting test results with TAP
  • Update mock response for details api to include subjectName and testSetName

What issues does this PR fix or reference?

@W-17237081@

Copy link
Contributor

@shetzel shetzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This takes the results after all tests have completed running and formats it as TAP. It's not a streaming implementation. This is all mocked for now anyway but if we want streaming TAP results it would be a different implementation.

@mdonnalley
Copy link
Contributor Author

This takes the results after all tests have completed running and formats it as TAP. It's not a streaming implementation. This is all mocked for now anyway but if we want streaming TAP results it would be a different implementation.

@shetzel For what it's worth, this is exactly how the apex commands handle the TAP format. It doesn't stream the results either.

I think it would be a big ask (and low priority) to ask either Sf Eval or the Apex teams to introduce a streaming API simply so we can support "proper" TAP streaming

@shetzel
Copy link
Contributor

shetzel commented Dec 16, 2024

This takes the results after all tests have completed running and formats it as TAP. It's not a streaming implementation. This is all mocked for now anyway but if we want streaming TAP results it would be a different implementation.

@shetzel For what it's worth, this is exactly how the apex commands handle the TAP format. It doesn't stream the results either.

I think it would be a big ask (and low priority) to ask either Sf Eval or the Apex teams to introduce a streaming API simply so we can support "proper" TAP streaming

The original TAP formatter for apex tests wasn't streaming but it would update during results polling. I think it was rewritten to just be a formatter after all results came back. I agree it's low priority now; just pointing it out in case it matters at some point.

@shetzel shetzel merged commit 7ff50ed into main Dec 16, 2024
15 checks passed
@shetzel shetzel deleted the mdonnalley/tap-format branch December 16, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants